search

dotnet-architecture / HealthChecks

Experimental Health Checks for building services, such as with ASP.NET Core
Other
454 stars 124 forks source link

UrlChecker should wait for any HTTP succesful state code. #30

Closed eiximenis closed 7 years ago

eiximenis commented 7 years ago

Currently UrlChecker expects only a 200 HTTP Status code

Any valid HTTP OK status code should be valid (i.e. thinking about a "Ping" URL that returns just a 204)

bradwilson commented 7 years ago

We're going to accept this change, but the code does not contain unit tests (it would break an existing test). It's a trivial update, so I'll implement it myself.

Thanks for the PR!