search

dotnet-architecture / HealthChecks

Experimental Health Checks for building services, such as with ASP.NET Core
Other
454 stars 124 forks source link

Already implemented in an Open Source project #8

Closed alhardy closed 7 years ago

alhardy commented 7 years ago

Looks like this come from a Metrics.Net extension written for dotnet core.

My implementation written a while back looks very similar, feel as though my efforts in open sourcing will be wasted :(

Here's the Repo

Eilon commented 7 years ago

Hi @alhardy this looks like it's a coincidence because the two projects are in very similar areas, so some types and members have similar names. All the contributions to the repo here are original.

glennc commented 7 years ago

@alhardy This library is purely a way to define a set of functions that you can run to determine the health of your application, with the associated middleware and other pieces to allow it to work with ASP.NET and ASP.NET Core. AppMetrics appears to be significantly more than that.

Happy to work with you on defining what the IHealthCheckResult, IHealthCheck and IHealthCheckService interfaces should look like and discuss the ability to smoothly switch between this and your efforts.

alhardy commented 7 years ago

@Eilon Not saying otherwise, just pointing out that there is already pretty much the same implementation.

@glennc Cheers, I'll try plugging in this implementation instead of mine a little down the track.