search

dotnet-architecture / eShopOnContainers

Cross-platform .NET sample microservices and container based application that runs on Linux Windows and macOS. Powered by .NET 7, Docker Containers and Azure Kubernetes Services. Supports Visual Studio, VS for Mac and CLI based environments with Docker CLI, dotnet CLI, VS Code or any other code editor. Moved to https://github.com/dotnet/eShop.
https://dot.net/architecture
24.53k stars 10.36k forks source link

Modernization #2107

Closed ReubenBond closed 1 year ago

ReubenBond commented 1 year ago

This is a joint effort between @davidfowl & myself to modernize and clean up eShop. There is more to do, but we wanted to merge what we have so far before we continue.

@erjain, we have tested this locally in VS (launch & manually test + automated tests) and via docker compose, but we haven't tested beyond that (Kubernetes, Azure). I don't expect you to review this because the PR is far too large, but if you could run some of your own tests, that would be greatly appreciated.

Addresses #2070

erjain commented 1 year ago

This is great work, you guys nailed it. I'll review and test it.

ReubenBond commented 1 year ago

@erjain merge when ready

markheath commented 1 year ago

I think this update means that logs are no longer appearing in Seq. Is this intentional? There still is a Seq container in docker-compose.yml but its not picking anything up

davidfowl commented 1 year ago

Yes it’s intentional. We’re also not done with the clean up. This was just the first big set of changes