search

dotnet-architecture / eShopOnContainers

Cross-platform .NET sample microservices and container based application that runs on Linux Windows and macOS. Powered by .NET 7, Docker Containers and Azure Kubernetes Services. Supports Visual Studio, VS for Mac and CLI based environments with Docker CLI, dotnet CLI, VS Code or any other code editor. Moved to https://github.com/dotnet/eShop.
https://dot.net/architecture
24.58k stars 10.36k forks source link

Rollback API deleted by mistake on Webhook Client #2128

Closed RobertoBorges closed 11 months ago

davidfowl commented 1 year ago

Thanks @RobertoBorges, we should clean this up if it is indeed needed. I will leave feedback on the PR.

PS: Also, there are not tests for this part of the project 😞. Where is this endpoint used?

RobertoBorges commented 1 year ago

Thanks @RobertoBorges, we should clean this up if it is indeed needed. I will leave feedback on the PR.

PS: Also, there are not tests for this part of the project 😞. Where is this endpoint used?

This end point is used on the Webhook process where the subscription request a confirmation at this end point... Without it the Subscription verification by the WebHook API don't work when registering the WebHook Client.

this was the commit that removed the endpoint:

https://github.com/dotnet-architecture/eShopOnContainers/commit/df4eb4c124f9c656ff63ba3eef93e4704961add2#diff-8200407cc237c6fe9940cb6c2334070720f88bcd54b739d001bd8e51404487d5

davidfowl commented 8 months ago

OK finally getting around to understanding this better and I will put it back