search

dotnet-architecture / eShopOnContainers

Cross-platform .NET sample microservices and container based application that runs on Linux Windows and macOS. Powered by .NET 7, Docker Containers and Azure Kubernetes Services. Supports Visual Studio, VS for Mac and CLI based environments with Docker CLI, dotnet CLI, VS Code or any other code editor. Moved to https://github.com/dotnet/eShop.
https://dot.net/architecture
24.58k stars 10.36k forks source link

Explicit reference to Duende.IdentityServer.EntityFramework.Storage not required #2131

Closed Pepsi1x1 closed 10 months ago

Pepsi1x1 commented 1 year ago

https://github.com/dotnet-architecture/eShopOnContainers/blob/06d5164532902a076813894c965d6c99122d39f2/src/Services/Identity/Identity.API/Identity.API.csproj#L12

Is this explicit reference required? It’s an implicit dependency of Duende.IdentityServer.EntityFramework

jamesmontemagno commented 11 months ago

Agreed, @vSrushtiPasari94 you can remove this and send a PR

SrushtiPasari94 commented 10 months ago

Dependency removed.