search

dotnet-architecture / eShopOnContainers

Cross-platform .NET sample microservices and container based application that runs on Linux Windows and macOS. Powered by .NET 7, Docker Containers and Azure Kubernetes Services. Supports Visual Studio, VS for Mac and CLI based environments with Docker CLI, dotnet CLI, VS Code or any other code editor. Moved to https://github.com/dotnet/eShop.
https://dot.net/architecture
24.58k stars 10.36k forks source link

Publish new release with working version for old sdks #2144

Open jyeros opened 10 months ago

jyeros commented 10 months ago

The releases with sdks version 2 and 3.0 are not working because the myget source specified in the nuget.Config is not available anymore as mentioned in https://github.com/dotnet-architecture/eShopOnContainers/issues/1575.

It would be nice if you can publish a patch for those sdks with working versions, so it is possible to test them.

jyeros commented 10 months ago

The changes implemented in this branch https://github.com/jyeros/eShopOnContainers/tree/3.0.0-without-myget are working without the myget source for SDK 3.0. See the Diff.

Similar on https://github.com/jyeros/eShopOnContainers/tree/2.0.8-without-myget

jamesmontemagno commented 10 months ago

This looks pretty good, are you able to send down a PR?

jyeros commented 10 months ago

This looks pretty good, are you able to send down a PR?

The base of the PRs should be tags 2.0.8 and 3.0.0. The problem is that I don't know how to open a PR having a tag as the base. I tried to use a branch, but I didn't see a branch in the commit where the tags are.