dotnet-foundation / projects

This repository is used for onboarding new projects
113 stars 31 forks source link

Moving TorchSharp to .NET Foundation #176

Closed NiklasGustafsson closed 2 years ago

NiklasGustafsson commented 3 years ago

1.   General Information

Project Name: TorchSharp

License: MIT

Contributor (Company, Organization or individual name(s)): Microsoft Corporation

Existing OSS Project? (Yes/No): Yes.

Source Code URL: https://github.com/xamarin/TorchSharp

Project Homepage URL (if different):

Project Transfer Signatories: Full legal name and email address required of the individual(s) with the authority to transfer or contribute the project to the .NET Foundation. Note that if you'd prefer not to include this in the public application, it can be submitted via e-mail to contact@dotnetfoundation.org (referencing this issue number).

2.   Description

TorchSharp provides .NET bindings to LibTorch, which is the deep learning and tensor math engine powering Pytorch. It mainly consists of a thin interop layer to the native library, which supports CPU and CUDA-based arithmetic. There is also a small set of utility functions implemented in .NET on top of the interop layer, most significantly for vision primitives.

Short description:

TorchSharp provides .NET bindings to LibTorch, the deep learning and tensor math engine powering Pytorch.

3.   Project Governance

Please complete this section about who will be maintaining the open source project and how it will run. Project Lead:

Name: Niklas Gustafsson Email: niklas.gustafsson@microsoft.com GitHub Profile URL: https://github.com/NiklasGustafsson

Committers:

Don Syme, Microsoft Niklas Gustafsson, Microsoft Miguel de Icaza, Microsoft

Governance Model:

Code changes are proposed and reviewed using the GitHub Pull Request (PR) system. PRs are reviewed and approved by the project committers in conference.

CLA

There has been no CLA in place for the existing OSS project, but all code currently in the master branch of the existing repository was written by Microsoft full-time employees.

CLA Notification Alias niklas.gustafsson@microsoft.com

Assignment Model. Under the .NET Foundation assignment model, project ownership and other intellectual property is assigned to the .NET Foundation and the .NET Foundation agrees to grant back a license to the contributor(s).

Contribution Model. Under the .NET Foundation contribution model, a project retains ownership of the copyright, but grants the .NET Foundation a broad license to the project’s code and other intellectual property. The project also confirms that the project’s submissions to .NET Foundation are its own original work (there are also instructions for any third party materials that might be included).

4.   Repository Layout

The .NET Foundation host guidance for new projects and details on recommended structure here: https://github.com/dotnet/home/tree/master/guidance

Note that the open source repository should be the master where changes are made by the core development team using the same PR process that is used for non-committer contributions.

Please define below any changes you would want to make to your repositories as part of the process of joining the .NET Foundation

5. Eligibility Criteria

Please complete the following for your project

6.   PR Plan

We are currently not ready for any kind of PR efforts around this library, and will continue to develop it and grow its community through word-of-mouth.

7.   Infrastructure Requirements

We will use standard Microsoft Azure DevOps CI as the build infrastructure. There are no web hosting or service hosting requirements. We would like advice about the standard practices for .NET Foundation projects with majority Microsoft contributions, and the simplest path to arranging appropriate code signing.

8.   Additional Notes

This project is conceptually related to ML.NET, but stands on its own. It is also similar to Tensorflow.NET under the SciSharp GitHub organization, which provides similar bindings to Tensorflow. TorchSharp is currently < v1.0. In other words, it is still a pre-release. We do currently not embed PDBs, but can enable it if required. A small amount of code as well as the overall API design, is inspired by Pytorch. Since the implementation languages are different, there are no instances of copied code, but some functions in the torch.vision namespace are directly inspired by the corresponding Python implementations, which are covered by a BSD-3 license.

ChrisSfanos commented 3 years ago

Hi everyone We will be following this checklist to onboard the project. Since it's a MSFT transfer, I'll work on the first two items in parallel to handing off the rest of the list

CLA

Project Onboarding

ChrisSfanos commented 3 years ago

Agreement is out for signing

NiklasGustafsson commented 3 years ago

Project Onboarding

ChrisSfanos commented 3 years ago

Project agreement is signed CLA bot is already enabled by default for all projects in the dotnet organization

ChrisSfanos commented 3 years ago

Once the code signing is wrapped up, we can close this item out - all other onboarding tasks are complete

NiklasGustafsson commented 3 years ago

Speaking of that, @ChrisSfanos, how is the code signing task proceeding? Do you need anything from me?

ChrisSfanos commented 3 years ago

I’m out of the process loop once the Trade Name is registered. Claire handles the remaining steps

Chris


From: Niklas Gustafsson @.> Sent: Wednesday, September 8, 2021 9:49:10 AM To: dotnet-foundation/projects @.> Cc: ChrisSfanos @.>; Mention @.> Subject: Re: [dotnet-foundation/projects] Moving TorchSharp to .NET Foundation (#176)

Speaking of that, @ChrisSfanoshttps://github.com/ChrisSfanos, how is the code signing task proceeding? Do you need anything from me?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dotnet-foundation/projects/issues/176#issuecomment-915401708, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKF5J34A5IKK5FMULLH3FLUA6HYNANCNFSM5B4Y6J6Q.

clairernovotny commented 3 years ago

@NiklasGustafsson It can take 1-3 weeks to get a cert from DigiCert depending on how long they take. We're working on getting it done ASAP.

NiklasGustafsson commented 3 years ago

@clairernovotny: Thanks for the heads up about the timeline!

NiklasGustafsson commented 2 years ago

Just so that we can prepare for when the cert is ready -- is there documentation or examples of how the code-signing service is supposed to be used within a Azure DevOps pipeline?

ChrisSfanos commented 2 years ago

Hi folks I'm working to clean up the onboarding projects still listed as open. Looks like the cert was the last item. What is the latest status?

Thanks!

NiklasGustafsson commented 2 years ago

@ChrisSfanos -- yes, we're done. Code signing has been working for a while. Thanks for the reminder.

ChrisSfanos commented 2 years ago

Awesome - that was the last item, so I'm closing this one out - thanks!