search

dotnet-presentations / blazor-workshop

Blazor workshop
https://aka.ms/blazorworkshop
MIT License
3.51k stars 1.56k forks source link

DeliveryMap-Cannot read property 'length' of null #308

Open RahimPasha opened 3 years ago

RahimPasha commented 3 years ago

Apparently, there is a little bug in DeliveryMap.js when markers is null at lines 21 and 40. It is not checking for null. line 21: if (map.addedMarkers.length !== markers.length){ line 40: markers.forEach((marker, index) => {

So, I changed line 21 to: if ((map.addedMarkers && markers) && (map.addedMarkers.length !== markers.length)) { and added a condition for the else at line 39: else if (markers) { It works perfect now.

lohithgn commented 2 years ago

@RahimPasha you should create Pull Request of the fix. Somebody from the team will review and take it forward.