search

dotnet-security-guard / roslyn-security-guard

Roslyn analyzers that aim to help security audit on .NET applications.
https://dotnet-security-guard.github.io
GNU Lesser General Public License v3.0
208 stars 38 forks source link

Visual Studio 2017 support #55

Closed suttonandy closed 7 years ago

suttonandy commented 7 years ago

Hi,

I've tried installing this on Visual 2017 RC and the extension does not appear. I see you only list Visual 2015 under 'Works with' on https://marketplace.visualstudio.com/items?itemName=PhilippeArteau.RoslynSecurityGuard.

My team leader is very keen to use this for our new .NET Core development project. Do you know when a version for Windows 2017 will be available? Many thanks.

h3xstream commented 7 years ago

I will look at this. It is most likely just a configuration in VSIX manifest file.

h3xstream commented 7 years ago

I have added Visual Studio 2017 support in the manifest. I have not installed Visual Studio 2017 RC yet.

You can test this dev build: RoslynSecurityGuard.Vsix.vsix.zip (Remove the .zip extension to use the VSIX)

h3xstream commented 7 years ago

The change to the VSIX is here 2a61e9e5c699d6bbe819ee364198c03c96788648

In case you prefer to recompile it yourself, you can use the master branch.

Mattacks commented 7 years ago

Why do you package it as a .zip? It just makes installation harder.

Mattacks commented 7 years ago

Do you expect the installer to do this?

VSIX Installer

The following extensions are not compatible with Visual Studio 15. Installation may cause Visual Studio to be unstable.

Do you want to continue?

Yes No

h3xstream commented 7 years ago

@Mattacks The zip extension was added because Github does not allow .vsix extension as attachment.

I will install VS 2017 to see what is missing.

h3xstream commented 7 years ago

@Mattacks I have migrated the project to VS 2017 and rebuild the extension with the latest VSSDK.

This time it should work without warnings: https://marketplace.visualstudio.com/items?itemName=PhilippeArteau.RoslynSecurityGuard