search

dotnet-state-machine / stateless

A simple library for creating state machines in C# code
Other
5.6k stars 766 forks source link

Github workflows/dotnet pack: Fix project path casing and directory separators #478

Closed crozone closed 2 years ago

crozone commented 2 years ago

Corrects the casing of the project path provided to dotnet pack. Also makes the directory separators '/' for consistency.

Second part of fix for https://github.com/dotnet-state-machine/stateless/issues/449

crozone commented 2 years ago

@ffMathy Could you please enable workflows for me on this PR? Just want to check that the changes to the .yml build config don't break the workflow build.

ffMathy commented 2 years ago

Yup, done 😊

crozone commented 2 years ago

Thanks. Build works and all tests passed. Looks like all the artifacts come out with the correct uppercase filename now:

MSBuild version 17.3.0+92e077650 for .NET
  Stateless -> D:\a\stateless\stateless\src\Stateless\bin\Release\netstandard2.0\Stateless.dll
  Stateless -> D:\a\stateless\stateless\src\Stateless\bin\Release\netstandard1.0\Stateless.dll
  Stateless -> D:\a\stateless\stateless\src\Stateless\bin\Release\net45\Stateless.dll
  Stateless -> D:\a\stateless\stateless\src\Stateless\bin\Release\net472\Stateless.dll
  TelephoneCallExample -> D:\a\stateless\stateless\example\TelephoneCallExample\bin\Release\netcoreapp2.1\TelephoneCallExample.dll
  JsonExample -> D:\a\stateless\stateless\example\JsonExample\bin\Release\netcoreapp2.1\JsonExample.dll
  BugTrackerExample -> D:\a\stateless\stateless\example\BugTrackerExample\bin\Release\netcoreapp2.1\BugTrackerExample.dll
  OnOffExample -> D:\a\stateless\stateless\example\OnOffExample\bin\Release\netcoreapp2.1\OnOffExample.dll
  Stateless -> D:\a\stateless\stateless\src\Stateless\bin\Release\net50\Stateless.dll
  Stateless.Tests -> D:\a\stateless\stateless\test\Stateless.Tests\bin\Release\net50\Stateless.Tests.dll

Build succeeded.

So PR did its job. OK to merge?

HenningNT commented 2 years ago

Looks good to me!