search

dotnet-state-machine / stateless

A simple library for creating state machines in C# code
Other
5.41k stars 746 forks source link

Release 5.14.0 #548

Closed mclift closed 7 months ago

mclift commented 8 months ago

As suggested by @HenningNT, this PR is for release 5.14.0.

crozone commented 7 months ago

Test failure, going to take a look:

Stateless.Tests.SynchronizationContextFixture.Multiple_OnEntry_on_Reentry_should_retain_SyncContext [FAIL] Failed Stateless.Tests.SynchronizationContextFixture.Multiple_OnEntry_on_Reentry_should_retain_SyncContext [47 ms] Error Message: Assert.NotEqual() Failure Expected: Not MaxConcurrencySyncContext { } Actual: MaxConcurrencySyncContext { }

mclift commented 7 months ago

Thanks, @crozone. Seems like that test is a little flaky: https://github.com/dotnet-state-machine/stateless/actions/runs/6746401636/job/18445672212#step:5:31

HenningNT commented 7 months ago

Might I suggest releasing as soon as possible after a useful change has been merged?

crozone commented 7 months ago

@mclift It looks like the issue is in the testing harness itself that tries to lose the sync context. There was an attempt to fix this here:

https://github.com/dotnet-state-machine/stateless/pull/528/files

But it looks like there still may be an issue with this strategy.

So Stateless isn't responsible for the failing test but the actual testing code. I think it's safe to proceed.

mclift commented 7 months ago

Thanks for checking that out, @crozone!