search

dotnet-state-machine / stateless

A simple library for creating state machines in C# code
Other
5.41k stars 746 forks source link

Add mermaid graph style #559

Closed sulmar closed 2 weeks ago

mclift commented 2 weeks ago

@sulmar Thanks for starting the work on this. I'll follow up soon with a PR to make it more complete, but please let me know if you're already working on it.

sulmar commented 2 weeks ago

@mclift Yes, before I asked you for refactoring, I created an independent project: https://github.com/sulmar/stateless-mermaid I would now like to move this solution to your library. Please let me know when is the best time to do this.

mclift commented 2 weeks ago

The code in sulmar/stateless-mermaid seems very close to the changes in your pull request. Would you mind if I built on your work to improve feature parity with the Graphviz style and add test coverage? I'd do this in the new feature branch and create a PR from there.

sulmar commented 2 weeks ago

Yes, it is very similar because the pull request was created based on this project. Sure, grab my code. I will be very happy because the stateless library is one of my favorites. I have given many presentations on it. For example on the MS Tech Summit 2022.

I also have another idea, but I'll work on it after your commit.

mclift commented 2 weeks ago

That's really cool! Okay, to be continued...