search

dotnet-websharper / core

WebSharper - Full-stack, functional, reactive web apps and microservices in F# and C#
https://websharper.com
Apache License 2.0
593 stars 52 forks source link

Trialing GraphBasedChecking with latest FCS #1329

Closed TheAngryByrd closed 1 year ago

TheAngryByrd commented 1 year ago

👋 I'm trying out some of the new GraphBasedChecking in the F# compiler. It's available currently in the 7.0.4xxx preview bits. The way to enable it is via OtherFlags such as:

<OtherFlags>$(OtherFlags) --test:GraphBasedChecking</OtherFlags>

However, the websharper task fails with this extra argument.

WEBSHARPERTASK : warning FS1063: Unknown --test argument: 'GraphBasedChecking' 
C:\Users\jimmy\.nuget\packages\websharper.fsharp\6.1.4.277\build\WebSharper.FSharp.targets(50,5): error MSB6006: "wsfsc.exe" exited with code 1.

I did a verbose build with dotnet build -v d but I wasn't able to get a stacktrace or anything else that was useful.

granicz commented 1 year ago

Yeah, we need to update to the latest FCS and we need to enable passing the new argument. @Jand42 Can we update FCS in the next build (on this or a new ticket)?

Jand42 commented 1 year ago

@TheAngryByrd @granicz Yes, I can make a new internal (github packages only for now) build with latest preview FCS, I'm tagging changes with this ticket.

Jand42 commented 1 year ago

@TheAngryByrd Build is 6.1.5.290

TheAngryByrd commented 1 year ago

Seems to not fail anymore! Thanks for jumping on it so quick. Ya'll are awesome :)

Feel free to close this if that's the workflow.

Jand42 commented 1 year ago

@TheAngryByrd Thanks, but I'll leave this open until there is a stable FCS build containing this flag then I can push out packages to nuget.org.