Additional claims topic enhancements

guardrex commented 4 years ago

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64faf33b-2511-5e8f-c1b0-94f32dc07fa4
Version Independent ID: 2697abc8-7727-2eba-74a5-fbbc8a7c80ff
Content: Persist additional claims and tokens from external providers in ASP.NET Core
Content Source: aspnetcore/security/authentication/social/additional-claims.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

HaoK commented 4 years ago

For more context on a related issue, there's a similar conversation here https://github.com/dotnet/aspnetcore/issues/5771

guardrex commented 2 years ago

@Rick-Anderson ... This is another one that I'm not finding the cycles to address due to Blazor work. A couple of ideas on this one ...

It could be closed as a won't-fix, but the discussion on the PU issues would be lost/obscured.
It could be worked, but it needs to go to another doc 🐈. Please re-assign if you want to go this way.
The two PU issues can be cross-linked in Additional resources ... AND I'll even provide the cross-links in a cut-'n-paste to make it quick AND if you like this idea ... I'll take care of this right now. 👂 I like this approach. I recommend it as a quick fix prior to this topic receiving a full overhaul one day, when these PU remarks can make it into the topic and the cross-links can be dropped. I'll even note that in a comment in the topic so that such a future doc author doesn't miss it.
```
* [Read access_token from logged in user (dotnet/aspnetcore #17905)](https://github.com/dotnet/aspnetcore/issues/17905)
* [Improve external login token/claim flow to identity in default templates (dotnet/aspnetcore #5771)](https://github.com/dotnet/aspnetcore/issues/5771)
```
If we adopt the cross-linking approach, let's ask @HaoK if he'll 🔒 the PU issues as Resolved to avoid any bikeshedding on them. Let's NOT go there! 😄

dotnet / AspNetCore.Docs