search

dotnet / AspNetCore.Docs

Documentation for ASP.NET Core
https://docs.microsoft.com/aspnet/core
Creative Commons Attribution 4.0 International
12.63k stars 25.3k forks source link

Nowin project references is discontinued #19034

Closed dmartensson closed 4 years ago

dmartensson commented 4 years ago

The Nowin project references is discontinued according to the owner so this guide should be revised as it should use active solutions.

As far as I can see there are no cross platform server suggested that supports websockets, since kestrel does not have that.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Rick-Anderson commented 4 years ago

@Tratcher should I remove the section Using ASP.NET Core Hosting on an OWIN-based server which features Nowin?

Tratcher commented 4 years ago

As far as I can see there are no cross platform server suggested that supports websockets, since kestrel does not have that.

Kestrel supports Upgrades, and WebSockets are supported on top of that via middleware. Do you mean there's no OWIN WebSocket middleware?

@Tratcher should I remove the section Using ASP.NET Core Hosting on an OWIN-based server which features Nowin?

It's still useful as an example. @dmartensson any suggestions for an active project to replace it with?

dmartensson commented 4 years ago

Hi

No, unfortunately I have not found any I could recommend and no guide to websockets on kestrel.

For most parts I can just start a webapi project under IIS, but in this case I was trying to build a webserver into a library and that proved to be a bit more of a problem ;)

A quick search found these but I have not tested any of them yet so I do not know if they are solving the problem: https://suave.io https://github.com/unosquare/embedio

Best regards

David

Den fre 3 juli 2020 kl 00:12 skrev Chris Ross notifications@github.com:

As far as I can see there are no cross platform server suggested that supports websockets, since kestrel does not have that.

Kestrel supports Upgrades, and WebSockets are supported on top of that via middleware. Do you mean there's no OWIN WebSocket middleware?

@Tratcher https://github.com/Tratcher should I remove the section Using ASP.NET Core Hosting on an OWIN-based server https://docs.microsoft.com/en-us/aspnet/core/fundamentals/owin?view=aspnetcore-2.1#using-aspnet-core-hosting-on-an-owin-based-server which features Nowin?

It's still useful as an example. @dmartensson https://github.com/dmartensson any suggestions for an active project to replace it with?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dotnet/AspNetCore.Docs/issues/19034#issuecomment-653240808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4ER4B4UI6K6URS3XNWKTRZUA5BANCNFSM4ONNO6XQ .

Tratcher commented 4 years ago

Here are the websocket docs: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/websockets?view=aspnetcore-3.1

You don't need OWIN for cross platform support, Kestrel already covers that.

dmartensson commented 4 years ago

Hi

are you sure it works with Kestrel. According to the documentation you linked IIS or HTTP.sys is a prerequisite

Prerequisites

-

ASP.NET Core 1.1 or later

Any OS that supports ASP.NET Core:

Den fre 3 juli 2020 kl 02:28 skrev Chris Ross notifications@github.com:

Here are the websocket docs: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/websockets?view=aspnetcore-3.1

You don't need OWIN for cross platform support, Kestrel already covers that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dotnet/AspNetCore.Docs/issues/19034#issuecomment-653271508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4ER3KUNLRJJYOMDDSTC3RZUQZBANCNFSM4ONNO6XQ .

davidfowl commented 4 years ago

Yes websockets works with kestrel 😄 .

dmartensson commented 4 years ago

Then that might be mentioned as many threads I found suggested that it was not supported, so I did not even bother trying. :)

Tratcher commented 4 years ago

That says If the app runs on Windows with IIS:.

The doc never mentions Kestrel because Kestrel doesn't have any prerequisites for WebSockets, it just works. It might be worth mentioning Kestrel for clarity though.