search

dotnet / AspNetCore.Docs

Documentation for ASP.NET Core
https://docs.microsoft.com/aspnet/core
Creative Commons Attribution 4.0 International
12.64k stars 25.28k forks source link

Docker-compose debug file guidance #22153

Open nrouelle opened 3 years ago

nrouelle commented 3 years ago

In the last section about docker-compose debug file for windows container, it seems the volume value has too many parameters https:\c:\https:ro. C: should not be there I think.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

guardrex commented 3 years ago

Thanks @nrouelle.

@ravipal ... That seems to have been on the original PR. Is it correct as shown?

Cross-reference to the PR: https://github.com/dotnet/AspNetCore.Docs/pull/17474/files

guardrex commented 3 years ago

Ping @ravipal

ravipal commented 3 years ago

I think you are referring to this line and it is correct. - ${USERPROFILE}\.aspnet\https:C:\https:ro The first part - ${USERPROFILE}\.aspnet\https is the host path and the second part C:\https is container path and the third part ro is the mode. Please see https://docs.docker.com/compose/compose-file/compose-file-v3/#short-syntax-3 for more information.

guardrex commented 3 years ago

Thanks @ravipal. Closing as answered.

Rick-Anderson commented 3 years ago

I think you are referring to this line and it is correct. - ${USERPROFILE}\.aspnet\https:C:\https:ro The first part - ${USERPROFILE}\.aspnet\https is the host path and the second part C:\https is container path and the third part ro is the mode. Please see https://docs.docker.com/compose/compose-file/compose-file-v3/#short-syntax-3 for more information.

@ravipal that's great information. Shouldn't I add it to this doc? cc @spboyer for his opinion.

guardrex commented 3 years ago

Let's re-open and re-title for now.

@Rick-Anderson ... I was going to work it as a quick fill-in task on my busy schedule 🏃, but I leave it to you.

spboyer commented 3 years ago

@Rick-Anderson - perhaps a NOTE: on the format may assist, but not crucial IMO