dotnet / AspNetCore.Docs

Documentation for ASP.NET Core
https://docs.microsoft.com/aspnet/core
Creative Commons Attribution 4.0 International
12.64k stars 25.28k forks source link

The information on this page for setting up an Apache proxy is incorrect and dangerous. #30207

Closed kevingolding2001 closed 1 year ago

kevingolding2001 commented 1 year ago

The instructions for setting up Apache say to turn ProxyRequests on. This is incorrect and dangerous. By doing so you turn Apache into an open proxy, which is ripe for abuse.

According to the Apache docs you don't need ProxyRequests on. You just need ProxyPass to set up a reverse proxy.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

guardrex commented 1 year ago

Hello @kevingolding2001 ... I had no personal knowledge on the subject at the time it was published. Unfortunately, I think our product unit member who was helping with Apache and Nginx had left the team. I thought that Artak had looked it over and approved of the guidance at https://github.com/dotnet/AspNetCore.Docs/issues/14323 (cc: @rpc-scandinavia). However, I can see from the many Internet resources that you are correct. I'll 🔪 that immediately and update the live document. I'll also search the whole repo and make sure it doesn't appear elsewhere.

kevingolding2001 commented 1 year ago

Thanks for the quick response. The cynical part of me was seeing weeks of pushback and arguing. But I'm glad to be wrong about that.