dotnet / AspNetCore.Docs

Documentation for ASP.NET Core
https://docs.microsoft.com/aspnet/core
Creative Commons Attribution 4.0 International
12.66k stars 25.28k forks source link

Additional security considerations for the input file component #33850

Open javiercn opened 1 month ago

javiercn commented 1 month ago

Description

Include a section about security considerations in for https://learn.microsoft.com/en-us/aspnet/core/blazor/file-uploads?view=aspnetcore-8.0#file-size-read-and-upload-limits

In addition to the section mentioned in the article above about limits, we should add a Security Considerations section to cover https://learn.microsoft.com/en-us/aspnet/core/mvc/models/file-uploads?view=aspnetcore-8.0#file-name-security and to explicitly call out avoiding the usage of the Size property in the IBrowserFile instance to impose a limit on the file size. (In other words, no file.OpenReadStream(file.Size))

Page URL

https://learn.microsoft.com/en-us/aspnet/core/blazor/file-uploads?view=aspnetcore-8.0

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/file-uploads.md

Document ID

c11d981c-05af-c19d-a333-feedd5978639

Article author

@guardrex

Related Issues

github-actions[bot] commented 1 month ago

๐Ÿ‚๐ŸŽƒ๐Ÿฎ Autumn Skies and Pumpkin Pies! ๐Ÿฅงโ˜•๐Ÿ‚

Stand by! A green dinosaur ๐Ÿฆ– will arrive shortly to assist.

guardrex commented 1 month ago

I'm adding this to the existing File Uploads article PR.

That PR should be merged fairly soon. I'm just waiting to hear back how it should address request streaming for non-Chromium browsers.

AND BTW ... I mention that we never showed how to use HTTP Ranges for large file uploads. We say to do it, but we provide no example. It's relevant for two scenarios now ...

This is all discussed in the PR's opening remarks.