Closed martinothamar closed 3 months ago
There was a segfault happening for the integration test that I don't quite understand. I can no longer reproduce it after the last commit. I tried to debug some dumps locally but was unable to find relevant exceptions, so my only guess atm is that the crash originates from unmanaged code. Since changing the init logic seemed to affect things, and the crash always happening during InProcessEmitToolchain
, I'm guessing it has something to do with attaching/detaching multiple times in the same process or something
In any case, I would like to test out using only the JetBrains API directly
The last commit simplifies the implementation of the tool by using only the Jetbrains API, and the lifetime of it is more clearly managed based on the incoming signals.
I'd be willing to try the same with dotTrace impl. I also want to make a flag like performExtraBenchmarksRun
similar to some of the other profilers. I could do these en subsequent PRs
@martinothamar thank you very much for this PR!
Implements
DotMemoryDiagnoser
to matchDotTraceDiagnoser
Common
package or just use<Compile Include="..." />
Sample output of
IntroDotMemoryDiagnoser