search

dotnet / CliCommandLineParser

A second-generation parser for the .NET Core command line tools
MIT License
111 stars 44 forks source link

Enable arcade-powered source-build. #177

Closed crummel closed 3 years ago

crummel commented 3 years ago

This enables source-build to support building the entire .NET SDK from source. See https://github.com/dotnet/source-build/blob/master/Documentation/planning/arcade-powered-source-build/README.md for more details.

MichaelSimons commented 3 years ago

Hey, @sfoslund, can you please review this when you get a chance?

sfoslund commented 3 years ago

This looks fine to me but I haven't worked with this repo before. @wli3 are you the right person to take a look?

wli3 commented 3 years ago

eng/source-build-patches/0001-Remove-test-and-sample-projects-from-solution.patch should be removed?

Also @crummel @MichaelSimons After net6.0, (master in sdk repo), we no longer use this repo. If source build only need to support net6.0 and on, we don't have to migrate this repo.

MichaelSimons commented 3 years ago

@wli3, dotnet/templating is currently referencing CliCommandLineParser as well. Is this reference going away in .NET 6.0 as well?

cc @dseefeld

wli3 commented 3 years ago

hmm... if templating is still referencing this repo, we should consider migrate it until they move out of this version of the parser.

Is this PR all that needed?

MichaelSimons commented 3 years ago

Is this PR all that needed?

No, This is the first of 4 phases described in the Arcade Powered Source-Build plan. This phase is the initial infra checkin with the current patches that exist within the existing source-build. The next phase is for the repo owners to work on eliminating the patches and enable CI.

wli3 commented 3 years ago

I think to simply things we should move forward on this repo unless it is very costly to do so. Is https://github.com/dotnet/command-line-api the replacement repo being part of this conversation?

MichaelSimons commented 3 years ago

Yes, command-line-api is also being included in source-build.

crummel commented 3 years ago

Hi @wli3, I don't have permissions to merge, we're ready to go forward on this if you are.