search

dotnet / EntityFramework.ApiDocs

Reference documentation for Entity Framework APIs
Creative Commons Attribution 4.0 International
17 stars 44 forks source link

Cleanup: remove Internal namespaces from API reference #10

Closed divega closed 5 years ago

divega commented 6 years ago

From @divega on June 5, 2017 22:18

E.g. https://docs.microsoft.com/en-us/ef/core/api/microsoft.entityframeworkcore.design.internal.

Copied from original issue: aspnet/EntityFramework.Docs#402

divega commented 6 years ago

There are still there in the new API reference, e.g. https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.design.internal?view=efcore-2.0, but they provider zero value and make the API reference really hard to navigate.

cc @dend

dend commented 6 years ago

@divega there is a way to filter those out. Will share on an internal thread after the holidays.

dend commented 6 years ago

This is now resolved.

divega commented 6 years ago

@dend I am reopening this. It seems it has regressed.

divega commented 6 years ago

@dend I still see lots of *.Internal namespaces in https://docs.microsoft.com/en-us/dotnet/api/?view=efcore-2.1.

smitpatel commented 5 years ago

This is no longer the case and should be closed.

mairaw commented 5 years ago

I still see them @smitpatel: image

smitpatel commented 5 years ago

I searched for .internal and it gave 0 results so I concluded it was corrected. My bad. What is the way to fix it? Re-generate the docs?

mairaw commented 5 years ago

You can just add the desired namespaces to this file similar to what was done to fix that for Microsoft.EntityFrameworkCore.Design.Internal: https://github.com/aspnet/EntityFramework.ApiDocs/blob/master/dotnet/xml/_filter.xml

mairaw commented 5 years ago

I'm assigning to myself.

smitpatel commented 5 years ago

@mairaw - When would this be on website? When does the tool run again to re-generate APIs?