Make it easier to use ILMerge console app via NuGet and MSBuild

dotnet / ILMerge

ILMerge is a static linker for .NET Assemblies.

MIT License

1.23k stars 170 forks source link

Make it easier to use ILMerge console app via NuGet and MSBuild #10

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

Changes:

Upgraded two projects to VS 2017: ILMerge and ILMerge.Tests.
Added a nuspec so package re-generates on build.
Updated README with example of usage.
Added MSBuild properties file to NuGet package that sets the property ILMergeConsolePath to the location of ILMerge.exe.

This takes care of item 2 from https://github.com/Microsoft/ILMerge/issues/9#issuecomment-296254866

cc @mike-barnett

msftclas commented 7 years ago

@natemcmaster, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

natemcmaster commented 7 years ago

By the way, I noticed that in 2.14, the package only includes ILMerge.exe. I assume this file has System.Compiler.dll merged into it. I left them separate for now to keep build as simple as possible. Is this okay? Or should we run ILMerge to combine the files?

Current layout:

mike-barnett commented 7 years ago

Yes, I had always used ILMerge on itself to simplify deployment for people: they could just copy the one file to wherever they needed to use it. However, I never made it a post-build step to simplify debugging. I'm fine with leaving them as two files. What do you think?

natemcmaster commented 7 years ago

Yeah, that makes sense. I've added a post-build step to do this.

natemcmaster commented 7 years ago

Ping @mike-barnett can you take a look at this when you have a minute? It should be ready to merge.

natemcmaster commented 7 years ago

Thanks @mike-barnett !