search

dotnet / ILMerge

ILMerge is a static linker for .NET Assemblies.
MIT License
1.23k stars 170 forks source link

Update GlobalSuppressions.cs #2

Closed naitp closed 7 years ago

naitp commented 7 years ago

Addresses issue found in https://github.com/Microsoft/ILMerge/issues/1 (Can't compile the code because of Chinese letters).

mike-barnett commented 7 years ago

Thanks so much! I don't know how that bad byte got in there. However, did you do something that would have committed the file without windows line endings (\r\n)? That appeared to be the case when I pulled the merged file. I just committed a version with the line endings renormalized to Windows line endings.

dmetzgar commented 7 years ago

That byte comes from encoding. If you use UTF instead of ASCII.

mike-barnett commented 7 years ago

What I meant is that none of the other files in that directory have the byte-encoding byte, so I don't know why that file would have it.

naitp commented 7 years ago

Regarding line endings, the only thing I can think of is that the ACE Editor converted them inadvertently when I saved the file (see last comment here: https://github.com/gitlabhq/gitlabhq/issues/3982 from Nov. 2016), but I can't seem to duplicate the issue on any of my repos. Sorry I couldn't be more help with this one. I'll try to duplicate it when I have some more time (when I'm not at work).

mike-barnett commented 7 years ago

No worries! I was just mentioning it because I thought I had put the right magic goo in .gitattributes so that Git would always put in the Windows line endings. I guess line endings and the great tab vs. spaces debate will always be among the great religious battles of the world...