search

dotnet / Kerberos.NET

A Kerberos implementation built entirely in managed code.
MIT License
520 stars 91 forks source link

Expose public setter for the `ClaimEntry` type #353

Closed TonyTroeff closed 1 year ago

TonyTroeff commented 1 year ago

Is your feature request related to a problem? Please describe. In one of the projects I work on, we need to assign values to the Id property of ClaimEntry instances.

Describe the solution you'd like If the Id property has a publicly exposed setter, we will be able to use it.

All the other properties are modifiable either through a publicly exposed setter, or the types used suppose mutability (Values is an IList<object> instances and we can freely add or remove items).

Describe alternatives you've considered Currently, we are using reflection to deal with this situation, however it is not efficient and quite unnecessary.

TonyTroeff commented 1 year ago

Should I close this issue since the PR was completed, or will it be automatically closed when a new version is released?

SteveSyfuhs commented 1 year ago

It'll close on it's own. Package is up: https://www.nuget.org/packages/Kerberos.NET/4.6.29