search

dotnet / MQTTnet

MQTTnet is a high performance .NET library for MQTT based communication. It provides a MQTT client and a MQTT server (broker). The implementation is based on the documentation from http://mqtt.org/.
MIT License
4.33k stars 1.04k forks source link

Release 2.5 #82

Closed chkr1011 closed 6 years ago

chkr1011 commented 6 years ago

I want to release a new version soon because we have lots of new features. Before doing this I want to summarize the open topics:

  1. Units Tests are not running for server tests. I am not able to fix them because I don't understand how to inject the test adapter since we have DI. @JanEggers Can you please have a look?
  2. @haeberle can you confirm that the bug with UWP is now fixed since latest changes from @JanEggers? If not I can also keep searching for a solution.
  3. @JTrotta does the ManagedClient have everything you need so far? We can add more features but I want to release it soon with the features it already has.
chkr1011 commented 6 years ago

@JanEggers I tried to implement the mentioned enum but I saw that it is not that easy. Then I tried to remove the RAW stream and always use the regular one. So also with the BufferedStream as the wrapper stream. I didn't get any errors with the TestApp.NetCore which also uses the BufferedStream. Both client and server are running perfectly. A ESP client is connected, sending data and also the UWP test app is connected with the server. So can you share some details how to reproduce the issues with the BufferedStream which requires the approach with the Raw-Stream access?

JanEggers commented 6 years ago

if it is running fine now then remove the raw streams. the issue was that the connect package was not received on either netcore or netfx because the buffered stream tried to read buffersize bytes and blocked but until the connect message is processed there where no further messages/bytes = deadlock. it may be possible that the issue i expierienced was one of the other issues we fixed while developing v2.5

chkr1011 commented 6 years ago

OK I will push my changes. Can you please check it with a quick test. I also ran several tests and it seems to work without any issues. I will now test it with an encrypted connection with Azure IoT Hub. If this works I tested all possible scenarios. And please check my code fur sure 😄

chkr1011 commented 6 years ago

Version 2.5 is now released! Thanks to everyone who has contributed!