search

dotnet / NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json.
MIT License
45 stars 61 forks source link

Bring back TFM #101

Closed dmonroym closed 3 years ago

dmonroym commented 3 years ago

Signed build complains about not having proper tools for this tfm so falling back to original

C:\A\1\24\s\.tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\A\1\24\s\setup\Swix\Microsoft.NuGet.Build.Tasks.Setup\Microsoft.NuGet.Build.Tasks.Setup.csproj]
##[error].tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: (NETCORE_ENGINEERING_TELEMETRY=Build) The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
C:\A\1\24\s\.tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\A\1\24\s\src\Microsoft.NuGet.Build.Tasks\Microsoft.NuGet.Build.Tasks.csproj]
##[error].tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: (NETCORE_ENGINEERING_TELEMETRY=Build) The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
C:\A\1\24\s\.tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\A\1\24\s\src\Microsoft.NuGet.Build.Tasks.Tests\Microsoft.NuGet.Build.Tasks.Tests.csproj]
##[error].tools\msbuild\16.8.0-preview2.1\tools\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1178,5): error MSB3644: (NETCORE_ENGINEERING_TELEMETRY=Build) The reference assemblies for .NETFramework,Version=v4.8 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

Build FAILED.
davkean commented 3 years ago

This TFM also needs to match the lowest that VS needs, are we sure that VS targets 4.8?

dmonroym commented 3 years ago

@davkean I brought it back down to 4.6 like it was originally. My intent was to modify some packages because I had been having trouble building and thought that by updating the TFM I might resolve it and it didn't so this PR just resets it