dotnet / NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json.
MIT License
45 stars 61 forks source link

Remove incorrect signing check #181

Closed haileymck closed 5 months ago

haileymck commented 5 months ago

pipeline run

This code signing validation is incompatible with Arcade pipelines. It is causing CodeSign.MissingSigningCert on all of the .dll that are in fact signed. This is because this code sign validation doesn't work with how this Arcade repo is signed. Thus, this code sign validation needs to be removed because it is an invalid check.

Signing is done here with the singing plugin and during build here: https://github.com/dotnet/NuGet.BuildTasks/blob/ffb0d794b8ddf3c7f227f305e4f5b73cd417fe8c/eng/common/templates-official/job/job.yml#L131 https://github.com/dotnet/NuGet.BuildTasks/blob/ffb0d794b8ddf3c7f227f305e4f5b73cd417fe8c/eng/common/build.ps1#L60

I have manually verified that the .dlls are in fact being signed. For example, we can see that the Microsoft.NuGet.Build.Tasks.dll is being signed here: image screenshot

Originally, this validation was copied over from a non-Arcade pipeline during the 1ES pipeline migration. In the future, we want to use Arcade signing validation in our pipeline; I created #180 to track.