search

dotnet / NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json.
MIT License
46 stars 61 forks source link

Add support for project.assets.json #21

Closed tmeschter closed 8 years ago

tmeschter commented 8 years ago

Update Microsoft.NuGet.targets to support project.assets.json files in addition to project.lock.json. If a project lock file has not been explicitly specified and there are no MyProj.project.json or project.json files next to the project, we'll look for $(BaseIntermediateOutputPath)project.assets.json instead.

dnfclas commented 8 years ago

Hi @tmeschter, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

tmeschter commented 8 years ago

@jasonmalinowski @rrelyea @drewgil Please review.

drewgillies commented 8 years ago

Looks great. :shipit:

tmeschter commented 8 years ago

Anyone else who should take a look at this? Also, I don't have permission to merge pull requests here.

tmeschter commented 8 years ago

@jasonmalinowski @drewgil I've updated the pull request to avoid producing items for content files when we're reading from project.assets.json (that is, when we're using PackageReferences).

drewgillies commented 8 years ago

:shipit:

tmeschter commented 8 years ago

@jasonmalinowski It turns out the second round of changes was unnecessary and I've backed it out. Who should I annoy to get this merged in? :-)

tmeschter commented 8 years ago

@Pilchie I'm not sure if it matters for the project.assets.json case since it should only be updated when the project file is updated, right?