search

dotnet / NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json.
MIT License
45 stars 61 forks source link

Unblock PackageReference restore for *.vcxproj files #49

Closed wjk closed 4 years ago

wjk commented 5 years ago

I have determined through manual testing that the ResolveNuGetPackageAssets task does not function under a *.vcxproj file, no matter what I try. Inspection of the task code reveals no indications of why it is failing. However, since this task is aimed towards restoring .NET assets, and that NuGet doesn't support .NET assets in C++/CLI projects anyway, this is not much of a loss. Skipping this task via setting $(ResolveNuGetPackages) to false allows the restore process to succeed.

Import of props/targets files in build/native folders of packages is not impacted by this change. This is especially important because the recommended/only way to do NuGet in a C++ project is to add props/targets files to the build using this method.

dmonroym commented 4 years ago

We've moved things around this repo. Please reopen this PR against master if you want us to take a look at this again.