search

dotnet / NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json.
MIT License
45 stars 61 forks source link

Condition mention of BeforeGenerateProjectPriFile only if needed #7

Closed jasonmalinowski closed 8 years ago

jasonmalinowski commented 8 years ago

If you have a target that mentions another target in BeforeTargets, but your target won't run, MSBuild still gives a warning. The workaround is to condition the computation of BeforeTargets as well. There's a bigger question here about where to move the .NET Core injection to, since it's ugly that it lives here; I ignore that question for now.

Fixes NuGet/Home#1814.

jasonmalinowski commented 8 years ago

Review: @NuGet/build-tasks-team

Pilchie commented 8 years ago

:+1:

hickford commented 8 years ago

If I may ask, which version of NuGet / Visual Studio has this fix?

yishaigalatzer commented 8 years ago

The fix is not in nuget, it's in the build task shipping in visual studio. @jasonmalinowski will know in what version. I can only assume it is in update 3

jasonmalinowski commented 8 years ago

This was shipped in Visual Studio 2015 Update 2.

hickford commented 8 years ago

Thanks.