Closed bdovaz closed 8 months ago
I once tried to convert this, but then the "Publish" step no longer generates the "Click Once" application. Did you check that this still works?
As you can see in https://dev.azure.com/tom-englert/Open%20Source/_build/results?buildId=6005&view=artifacts&pathAsName=false&type=publishedArtifacts the asset Publish.zip is now missing
As you can see in https://dev.azure.com/tom-englert/Open%20Source/_build/results?buildId=6005&view=artifacts&pathAsName=false&type=publishedArtifacts the asset Publish.zip is now missing
Actually the problem you mention is not possible to reproduce in a PR because the task you mention is only executed in the master branch:
But it has helped me to make that same check and with some small changes in MSBuild variables, I get it to generate it correctly.
The command that I have used to check it has been: msbuild ResxManager\ResxManager.csproj /target:publish
.
So this PR is ready to be merged if you give the go-ahead.
The target Publish
in an SDK style project does no longer create the click-once app
If it would have been that easy, I would have already done it.
On publish folder not, but I think because we are not providing a publish profile, because if I create one it correctly generates it:
To test it you need to:
<TargetFramework>net7.0-windows</TargetFramework>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<?xml version="1.0" encoding="utf-8"?>
<!--
https://go.microsoft.com/fwlink/?LinkID=208121.
-->
<Project>
<PropertyGroup>
<ApplicationRevision>1</ApplicationRevision>
<ApplicationVersion>1.0.0.*</ApplicationVersion>
<BootstrapperEnabled>True</BootstrapperEnabled>
<Configuration>Release</Configuration>
<CreateWebPageOnPublish>False</CreateWebPageOnPublish>
<GenerateManifests>true</GenerateManifests>
<Install>True</Install>
<InstallFrom>Disk</InstallFrom>
<IsRevisionIncremented>True</IsRevisionIncremented>
<IsWebBootstrapper>False</IsWebBootstrapper>
<MapFileExtensions>True</MapFileExtensions>
<OpenBrowserOnPublish>False</OpenBrowserOnPublish>
<Platform>Any CPU</Platform>
<PublishDir>bin\Release\net7.0-windows\win-x86\app.publish\</PublishDir>
<PublishUrl>bin\publish\</PublishUrl>
<PublishProtocol>ClickOnce</PublishProtocol>
<PublishReadyToRun>False</PublishReadyToRun>
<PublishSingleFile>True</PublishSingleFile>
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
<SelfContained>False</SelfContained>
<SignatureAlgorithm>(none)</SignatureAlgorithm>
<SignManifests>False</SignManifests>
<SkipPublishVerification>false</SkipPublishVerification>
<TargetFramework>net7.0-windows</TargetFramework>
<UpdateEnabled>False</UpdateEnabled>
<UpdateMode>Foreground</UpdateMode>
<UpdateRequired>False</UpdateRequired>
<WebPageFileName>Publish.html</WebPageFileName>
</PropertyGroup>
<ItemGroup>
<BootstrapperPackage Include="Microsoft.NetCore.DesktopRuntime.7.0.x86">
<Install>true</Install>
<ProductName>.NET Desktop Runtime 7.0.13 (x86)</ProductName>
</BootstrapperPackage>
</ItemGroup>
</Project>
msbuild ResxManager\ResxManager.csproj /target:publish /p:PublishProfile="ResXManager\Properties\PublishProfiles\ClickOnceProfile.pubxml" /p:PublishDir="PublishTestPath"
Most of it is in the project itself, I think <PublishProtocol>ClickOnce</PublishProtocol>
is the missing link - I'll give it a try.
Yes, that did the trick; thanks for helping to remove this annoying leftover.
Superseded by #605
When #593 is merged I make the necessary changes to support CPM.
@tom-englert please check that what I have deleted is not needed in the new format. I think it is but I need a review from someone else just in case.