search

dotnet / ResXResourceManager

Manage localization of all ResX-Based resources in one central place.
MIT License
1.29k stars 211 forks source link

Target .NET 7 in Standalone version #607

Open bdovaz opened 8 months ago

bdovaz commented 8 months ago
  1. I have added target net7.0 / net7.0-windows in all projects to be able to use an updated code base to .NET 7 with the benefit that you get from it in the standalone / ClickOne version.
  2. I have changed the target of the ResXManager project from .NET Framework to .NET 7.
  3. I have changed the ClickOnce profile dependencies so that it installs the .NET 7 runtime.
  4. I have removed the net472 target in Model / Infrastructure projects because with netstandard2.0 it is already implicit: https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version
  5. I have replaced WindowsAPICodePack-Shell with Microsoft-WindowsAPICodePack-Shell which is an updated fork, the previous one has compatibility problems being abandoned: https://www.nuget.org/packages/Microsoft-WindowsAPICodePack-Shell/#readme-body-tab

@tom-englert about your https://github.com/dotnet/ResXResourceManager/issues/598#issuecomment-1793785001 concern.

There have been 4-5 warnings generated when targeting .NET 7 but I think they are all fixable without having to do conditional code. I can solve them or if you want, compile it yourself from this branch and take a look at them to see what to do with each one.

bdovaz commented 8 months ago

In fact, you can see the wanings here:

https://dev.azure.com/tom-englert/Open%20Source/_build/results?buildId=6053&view=results

tom-englert commented 8 months ago

Again: Which serious issue would that fix?

bdovaz commented 8 months ago

No serious problem, just not using old frameworks (where possible == standalone version) in a project that is still under development and continuous maintenance.

The benefits are as I say, use a more updated code base and unless any API changes, it is transparent to us. And as you can see, there are 4 or 5 warnings when targeting .NET 7 but they are easy to fix if you want to fix them because I see that the project currently has some other info or warning issues not fixed (I think I remember).

tom-englert commented 7 months ago

https://github.com/dotnet/ResXResourceManager/pull/593#issuecomment-1793775063

Here you reacted with thumbs up, and now you are doing it just again ❓

bdovaz commented 7 months ago

#593 (comment)

Here you reacted with thumbs up, and now you are doing it just again ❓

I simply had a conflict in a csproj that could be resolved through the GitHub web interface and I fixed it.