search

dotnet / ResXResourceManager

Manage localization of all ResX-Based resources in one central place.
MIT License
1.29k stars 211 forks source link

Remove PrefixFieldType to just use boolean flags instead #609

Closed justinswork closed 7 months ago

justinswork commented 7 months ago

@tom-englert the PrefixFieldType deserialization was not handled properly for backwards compatibility. If I had serialized a value that is no longer supported, it crashes when trying to apply translations.

This change just removes the deprecated property, and uses the boolean flag values that have their corresponding checkbox in the configuration page.

tom-englert commented 7 months ago

Actually, there are no values that are no longer supported, since only one value has been added, there must be left overs from your intermediate branch.

Anyway, this PR is a sample for an ubiquitous pattern I stumble over every day: I s.o. finds a bug, a local workaround is added in the place where the bug was observed the first time, but the bug is still there, and probably will hit again later on another place.

So if we find that the configuration can't handle unknown enums gracefully, we better fix the configuration, rather than remove the use of enums where the issue popped up.

tom-englert commented 7 months ago

Superseded by bb8834e