dotnet / Scaffolding

Code generators to speed up development.
MIT License
620 stars 218 forks source link

Remove encoding override #2792

Closed tlmii closed 1 month ago

tlmii commented 1 month ago

Spectre.Console has logic in it to detect the output encoding of the shell being used, but we had a line in AnsiConsoleLogger that always overrode that to make it be Utf8. That worked ok in a lot of shells that were Utf8 natively (like powershell core) but some (e.g. Windows Powershell) did not have Utf8 enabled by default and this led to rendering bugs like this:

image

Removing this one line appears to allow the default detection through

tlmii commented 1 month ago

/backport to release/9.0-preview5

github-actions[bot] commented 1 month ago

Started backporting to release/9.0-preview5: https://github.com/dotnet/Scaffolding/actions/runs/9401931778