search

dotnet / Scaffolding

Code generators to speed up development.
MIT License
688 stars 230 forks source link

fix telemetry flow #3054

Closed deepchoudhery closed 3 weeks ago

deepchoudhery commented 4 weeks ago

issue started with first time dotnet-scaffold use not detecting any categories, delved deeper and found a bunch of issues.

  1. dotnet-scaffold-aspnet and dotnet-scaffold-aspire first time sentinel files were being created even when invoked through dotnet-scaffold.
  2. led to environment variable TelemetryConstants.DOTNET_SCAFFOLD_TELEMETRY_STATE not being passed correctly. Passing it in all dotnet invocations now.
  3. this subsequently fixed the issue at the top, since first time sentinel text was being presented instead of the appropriate get-commands result
tlmii commented 4 weeks ago

/azp run

tlmii commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
deepchoudhery commented 3 weeks ago

/backport to release/9.0

github-actions[bot] commented 3 weeks ago

Started backporting to release/9.0: https://github.com/dotnet/Scaffolding/actions/runs/11580361411