dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

Update Azure dependencies to latest stable versions #2808

Closed SimonCropp closed 1 month ago

SimonCropp commented 2 months ago
JRahnama commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 2 pipeline(s).
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.06%. Comparing base (321080e) to head (7f5b39c). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2808 +/- ## ========================================== - Coverage 72.06% 72.06% -0.01% ========================================== Files 299 299 Lines 61436 61436 ========================================== - Hits 44275 44272 -3 - Misses 17161 17164 +3 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2808/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.90% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.99% <ø> (+0.01%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.24% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JRahnama commented 2 months ago

I was wondering if we could apply the same approach to Azure.Core that @ErikEJ used for Microsoft.Identity.Client in PR #2577.

A minor concern would be Azure.Identity is referencing Azure.Core >=1.40.0 and we try to reference v1.42.0

cheenamalhotra commented 2 months ago

@DavoudEshtehari Since the version bumps are minor versions - can this be tagged as a non-breaking change? Unless you want to elaborate your understanding here?

DavoudEshtehari commented 2 months ago

Thanks @cheenamalhotra, there was confusion due to a major version bump of a transient dependency affecting versions 4.0 and earlier, which does not apply here.

cheenamalhotra commented 1 month ago

@SimonCropp

Please update as below (latest):