search

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 287 forks source link

Advance column index to avoid double clean. #2825

Closed mdaigle closed 2 months ago

mdaigle commented 2 months ago

Addresses an issue where failure to decrypt an encrypted column value leaves unread bytes either in the buffer or on the wire. If the internal connection is pooled, these bytes interfere with the next operation.

saurabh500 commented 2 months ago

Of course tests would be nice 😀 but I know you are working on them

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.02%. Comparing base (f8f2a96) to head (3ed1412). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2825 +/- ## ========================================== + Coverage 72.01% 72.02% +0.01% ========================================== Files 299 299 Lines 61394 61433 +39 ========================================== + Hits 44215 44250 +35 - Misses 17179 17183 +4 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2825/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.90% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.96% <100.00%> (+0.01%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arellegue commented 2 months ago

Is this fix not required in .NetFx branch?

mdaigle commented 2 months ago

Is this fix not required in .NetFx branch?

Yes, I had been having an issue with the test in netfx, but I just resolved it. I have a PR open here to add to netfx: #2843