Closed edwardneal closed 1 month ago
Attention: Patch coverage is 88.88889%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 72.06%. Comparing base (
d89372a
) to head (f661aab
). Report is 59 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@edwardneal scratch what I said. I just had a hallway conversation with @David-Engel We should be OK to take this forward.
That's great, thanks @saurabh500. If that changes, I can split the PR so that we remove CTAIP support and the .NET Framework-specific SSL callbacks separately.
Picking up from a comment on #2828.
This removes anything guarded behind ADONET_CERT_AUTH and ADONET_ORIGINAL_CLIENT_ADDRESS symbols. It then cleans up the knock-on effects of this: an unused Certificate option in the connection string, the PInvokes and their now-unreferenced structs, a delegate type.
The PR touches quite a few files, but it's necessary to start approaching any merge of SqlConnection.
/cc @JRahnama