Closed benrr101 closed 2 months ago
on the built M.D.SqlClient.xml in artifacts\Project\bin\Windows_NT\Release.AnyCPU\Microsoft.Data.SqlClient\netcore\net6.0 folder I see
<member name="M:Microsoft.Data.SqlClient.SqlBulkCopyColumnMapping.#ctor(System.String,System.String)">
<!-- No matching elements were found for the following include tag --><include file="../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlBulkCopyColumnMapping.xml" path="docs/members[@name="SqlBulkCopyColumnMapping"]/ctor[@name="sourceColumnStringAnddestinationColumnString"]/*" />
</member>
@JRahnama thanks for pointing that out. I'll add the fix for it to the next PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.02%. Comparing base (
d89372a
) to head (31f8cf1
). Report is 15 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@JRahnama sorry I though I already merged this one. I'll cherry pick the fixes from the next pr back into this one!
Description: This PR is the first of several that aim to fix https://github.com/dotnet/SqlClient/issues/2013. As per discussion on that issue, this PR removes Markdown style comments and replaces them with XML style comments.
This batch also takes into consideration the comments from the previous PR, so hopefully there will be less corrections required on this PR.
One open question - the
cref
format requires using a prefix for the type of the thing being reference (eg,M:
for method,T:
for types). However, it's unclear how the reference should be done for overloads, either specifying all overloads or specifying a single overload. The sandcastle docs sayO:
can be used to refer to all overloads (https://ewsoftware.github.io/XMLCommentsGuide/html/983fed56-321c-4daf-af16-e3169b28ffcd.htm#Examples)? The markdown docs use%2A
(*
) in cref's quite a bit, which I think effectively refers to all overloads, and those should be replaced withO:
prefix? Please let me know any thoughts on this