XML documentation corrections - batch 1

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.

MIT License

857 stars 286 forks source link

XML documentation corrections - batch 1 #2836

Closed edwardneal closed 1 month ago

edwardneal commented 2 months ago

This pulls my comments from #2822 into a separate PR now that it's merged.

/cc @benrr101 @JRahnama

benrr101 commented 2 months ago

@edwardneal Sorry it took me so long to review this, I wanted to finish up the structural changes before looking at content changes. Thanks for looking over the docs and helping us improve them. I'm happy with these changes, but I need two changes before checking it in:

Can you update the PR and resolve the conflict?
So unfortunately, I had to roll back deleting the sample files. Can you also make the change to the sample file in \doc\samples\CustomDeviceCodeFlowAzureAuthenticationProvider.cs

David-Engel commented 2 months ago

Note: CustomDeviceCodeFlowAzureAuthenticationProvider.cs was recently updated in #2821 and then synced to the snippet in #2837. Be sure to include those improvements in your PR.

edwardneal commented 1 month ago

Thanks for the review @benrr101 and @David-Engel. I've merged, resolved and responded