dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

[5.2] | Fix strong name in AKV provider #2845

Closed dauinsight closed 2 months ago

cheenamalhotra commented 2 months ago

Why is this issue patched in all branches? Are you building AKV provider from all servicing branches?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.73%. Comparing base (da57fa9) to head (946cb16). Report is 3 commits behind head on release/5.2.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/5.2 #2845 +/- ## =============================================== + Coverage 72.59% 72.73% +0.14% =============================================== Files 310 310 Lines 61930 61930 =============================================== + Hits 44958 45045 +87 + Misses 16972 16885 -87 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2845/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.88% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `76.97% <ø> (+0.18%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.39% <ø> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DavoudEshtehari commented 2 months ago

Why is this issue patched in all branches? Are you building AKV provider from all servicing branches?

Currently, we have two different versions of AKV, requiring at least two branches for each version. Since its source code resides within MDS, we manage it under the MDS servicing branches. When releasing a potential AKV hotfix, we can decide which version to use, but it can't be solely from the main branch. Additionally, OneBranch pipeline runs won’t function properly without this change.

cheenamalhotra commented 2 months ago

Thanks for the clarification @DavoudEshtehari