search

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

Fix | Increase routing attempt to 10 in netcore for LoginNoFailover and adding routing support to LoginWithFailover #2873

Closed JRahnama closed 1 month ago

JRahnama commented 2 months ago

fixes issue #2872

JRahnama commented 2 months ago

It seems like the Azure triggers are not working to validate this PR.

JRahnama commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.
cheenamalhotra commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 37.77778% with 56 lines in your changes missing coverage. Please review.

Project coverage is 72.02%. Comparing base (95cd389) to head (40f03aa). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 13.63% 38 Missing :warning:
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 66.66% 12 Missing :warning:
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 44.44% 5 Missing :warning:
....SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2873 +/- ## ========================================== - Coverage 72.11% 72.02% -0.09% ========================================== Files 299 299 Lines 61436 61506 +70 ========================================== - Hits 44303 44301 -2 - Misses 17133 17205 +72 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2873/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.90% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.93% <18.51%> (-0.09%)` | :arrow_down: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.24% <64.86%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.