search

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
859 stars 288 forks source link

Cleanup | DbConnectionInternal #2934

Closed benrr101 closed 2 weeks ago

benrr101 commented 3 weeks ago

Description: This is the second half of #2910 that applies cleanup to DbConnectionInternal. The PR is meant to be highly granular with each commit being individually reviewable. Ideally, I'd recommend going through the PR commit-by-commit and review each cleanup change.

Testing: Test cases are still passing, so I suspect this is a safe change.

cheenamalhotra commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (39c4604) to head (e92fbf9). Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs 81.08% 28 Missing :warning:
...icrosoft/Data/SqlClient/SqlDelegatedTransaction.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2934 +/- ## ========================================== + Coverage 71.92% 72.24% +0.32% ========================================== Files 294 291 -3 Lines 60342 59766 -576 ========================================== - Hits 43398 43178 -220 + Misses 16944 16588 -356 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2934/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2934/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.90% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2934/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.82% <79.72%> (-0.02%)` | :arrow_down: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2934/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.61% <80.82%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.