dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
860 stars 288 forks source link

Suppress roslyn errors and warnings #2936

Closed cheenamalhotra closed 3 weeks ago

cheenamalhotra commented 3 weeks ago

Suppresses roslyn errors/warnings captured in CI:

##[warning]3. RoslynAnalyzers Warning CA5398 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs. Line: 770. Column 52. 
Tool: RoslynAnalyzers: Rule: CA5398 (Avoid hardcoded SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5398
Avoid hardcoding SslProtocols 'Tls12' to ensure your application remains secure in the future. Use 'None' to let the Operating System choose a version.

##[error]4. RoslynAnalyzers Error CA5397 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs. Line: 822. Column 89. 
Tool: RoslynAnalyzers: Rule: CA5397 (Do not use deprecated SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5397
Transport Layer Security protocol version 'Tls11' is deprecated.  Use 'None' to let the Operating System choose a version.

##[warning]5. RoslynAnalyzers Warning CA5398 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs. Line: 416. Column 40. 
Tool: RoslynAnalyzers: Rule: CA5398 (Avoid hardcoded SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5398
Avoid hardcoding SslProtocols 'Tls13' to ensure your application remains secure in the future. Use 'None' to let the Operating System choose a version.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.25%. Comparing base (39c4604) to head (ece8cb8). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2936 +/- ## ========================================== + Coverage 71.92% 72.25% +0.33% ========================================== Files 294 291 -3 Lines 60342 59769 -573 ========================================== - Hits 43398 43185 -213 + Misses 16944 16584 -360 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.90% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.83% <ø> (+<0.01%)` | :arrow_up: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.59% <ø> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.