Closed mdaigle closed 2 weeks ago
Looks like this includes your previous PR?
Looks like this includes your previous PR?
@ErikEJ yes, this is building on the previous PR. I'll move it out of draft when the previous PR merges.
Attention: Patch coverage is 85.71429%
with 2 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
main@fc0acc0
). Learn more about missing BASE report. Report is 11 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...c/Microsoft/Data/SqlClient/Server/SqlNormalizer.cs | 0.00% | 1 Missing :warning: |
....SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
Building on #2927. That PR should merge first.
This PR includes a few different types of preprocesser directive cleanups:
#if NET6_0_OR_GREATER
and#if NET8_0_OR_GREATER
#if NETFRAMEWORK
#if NETX_0_OR_GREATER
#if NETX_0_OR_GREATER
with#if NET