Open mdaigle opened 3 weeks ago
Am curious - is there any net9.0 API that's actually needed/used? If not, is there a specific reason to add the net9.0 TFM?
@roji JSON support in SqlDbType: https://github.com/dotnet/runtime/issues/103925
@David-Engel of course, I forgot about that, thanks :)
You should be able to add:
- task: UseDotNet@2
displayName: 'Use .NET 9.x sdk'
inputs:
packageType: sdk
version: '9.x'
installationPath: $(Agent.ToolsDirectory)/dotnet
- task: UseDotNet@2
displayName: 'Install .NET 8.x runtime'
inputs:
packageType: runtime
version: '8.x'
installationPath: $(Agent.ToolsDirectory)/dotnet
Before this line, as a first step: https://github.com/dotnet/SqlClient/blob/8d500a3c63c6f2d57edb67a31f21aa6346581741/eng/pipelines/common/templates/steps/ci-project-build-step.yml#L37
That should get the build going. You probably need to cache a few more packages in the "official" feed.
Have a look at my attempt on getting it to work
You should be able to add:
- task: UseDotNet@2 displayName: 'Use .NET 9.x sdk' inputs: packageType: sdk version: '9.x' installationPath: $(Agent.ToolsDirectory)/dotnet - task: UseDotNet@2 displayName: 'Install .NET 8.x runtime' inputs: packageType: runtime version: '8.x' installationPath: $(Agent.ToolsDirectory)/dotnet
Before this line, as a first step:
That should get the build going. You probably need to cache a few more packages in the "official" feed.
Have a look at my attempt on getting it to work
Thanks @MichelZ, I'll give that a shot. I had issues previously with the sdk version resolver picking up the .NET 9 rc version when installing that way, but it may be working better now with the GA version available.
Attention: Patch coverage is 35.71429%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 72.80%. Comparing base (
b1f7eaf
) to head (fe363e2
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...c/Microsoft/Data/SqlClient/Server/SqlNormalizer.cs | 0.00% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Opening this up to get CI running on it. Duplicating #2674 to have my own workspace.