dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
860 stars 288 forks source link

XUnit does not support public async void in next version #2947

Closed MichelZ closed 2 weeks ago

MichelZ commented 3 weeks ago

The next version of XUnit does not support public async void in test methods. This should be changed to public async Task

https://dotnet.social/@xunit/112265523775265162

More recent versions of XUnit 2.x also issue a Warning - which gets treated as an Error in this project.

Wraith2 commented 2 weeks ago

If you're working on tests is there any way you can make them work in visual studio? currently the netcore tests all fail because of missing sni. It'd also be really nice if the test conditions evaluated and worked correctly. They haven't for as long as i've worked on this library.

MichelZ commented 2 weeks ago

At least with current main it seems that I can run unit tests from VS Test Explorer: Image