dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
859 stars 288 forks source link

Align Type aliases between netfx and netcore #2957

Open MichelZ opened 2 weeks ago

MichelZ commented 2 weeks ago

This PR solely aligns type aliases between netfx and netcore versions so they can be merged easier later.

Part of #2953

MichelZ commented 2 weeks ago

Looks good, but going forward, I think we can combine a couple of PRs like this together. I'm starting to get fatigue from reviewing these all independently 😅

Apologies, I really thought it makes it easier for review to have smaller, more targeted PR's... Guess I was wrong :) Will combine them in the future

benrr101 commented 2 weeks ago

There's definitely a balance :) I think we'll still take stuff when it's bite-sized like this, but it just might be slow with all the overhead. On the other hand, gigantic PRs are a lot more likely to just be outright rejected

benrr101 commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.18%. Comparing base (2151501) to head (36fd740). Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 87.50% 8 Missing :warning:
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2957 +/- ## =========================================== - Coverage 92.58% 73.18% -19.40% =========================================== Files 6 288 +282 Lines 310 65607 +65297 =========================================== + Hits 287 48014 +47727 - Misses 23 17593 +17570 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2957/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.80% <0.00%> (?)` | | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `71.31% <87.50%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benrr101 commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
MichelZ commented 1 week ago

AZP needs a smack on the head

MichelZ commented 3 days ago

@cheenamalhotra Anything I can do to move this along? Thx