Open MichelZ opened 2 weeks ago
Looks good, but going forward, I think we can combine a couple of PRs like this together. I'm starting to get fatigue from reviewing these all independently 😅
Apologies, I really thought it makes it easier for review to have smaller, more targeted PR's... Guess I was wrong :) Will combine them in the future
There's definitely a balance :) I think we'll still take stuff when it's bite-sized like this, but it just might be slow with all the overhead. On the other hand, gigantic PRs are a lot more likely to just be outright rejected
/azp run
Attention: Patch coverage is 86.15385%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 73.18%. Comparing base (
2151501
) to head (36fd740
). Report is 12 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs | 87.50% | 8 Missing :warning: |
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/azp run
AZP needs a smack on the head
@cheenamalhotra Anything I can do to move this along? Thx
This PR solely aligns type aliases between netfx and netcore versions so they can be merged easier later.
Part of #2953