search

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
860 stars 288 forks source link

Align ADP.IsEmpty -> string.IsNullOrEmpty #2961

Closed MichelZ closed 2 weeks ago

MichelZ commented 2 weeks ago

This PR simply changes ADP.IsEmpty to string.IsNullOrEmpty to align netfx with netcore

Part of #2953

MichelZ commented 2 weeks ago

@cheenamalhotra Could you also run this pipeline? Thx :)

cheenamalhotra commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
ErikEJ commented 2 weeks ago

@benrr101 IsNullOrEmpty did not exist in .NET Framework 1 😅

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (9d5ca32) to head (b20df43). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2961 +/- ## ========================================== + Coverage 72.31% 72.34% +0.02% ========================================== Files 288 288 Lines 59660 59660 ========================================== + Hits 43145 43162 +17 + Misses 16515 16498 -17 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2961/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.39% <ø> (-0.04%)` | :arrow_down: | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.76% <71.42%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.