search

dotnet / SqlClient

Microsoft.Data.SqlClient provides database connectivity to SQL Server for .NET applications.
MIT License
857 stars 286 forks source link

Merge | Interop NtDll Namespace #2983

Closed benrr101 closed 1 week ago

benrr101 commented 1 week ago

Description: This PR is the next phase of the interop namespace migration. This PR targets files that are related to the ntdll dlls. It's the same strategy as before - each commit should build by itself, they move a single file at a time. Files that has multiple classes/structs/etc in it are split into one file per class/struct/etc.

Testing: No functional changes made, just moving files around. Should be good if the build passes

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (2151501) to head (1b1165a). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/Microsoft/Data/SqlTypes/SqlFileStream.Windows.cs 0.00% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2983 +/- ## =========================================== - Coverage 92.58% 72.50% -20.08% =========================================== Files 6 288 +282 Lines 310 59529 +59219 =========================================== + Hits 287 43159 +42872 - Misses 23 16370 +16347 ``` | [Flag](https://app.codecov.io/gh/dotnet/SqlClient/pull/2983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | Coverage Δ | | |---|---|---| | [addons](https://app.codecov.io/gh/dotnet/SqlClient/pull/2983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `92.58% <ø> (ø)` | | | [netcore](https://app.codecov.io/gh/dotnet/SqlClient/pull/2983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `75.39% <0.00%> (?)` | | | [netfx](https://app.codecov.io/gh/dotnet/SqlClient/pull/2983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet) | `70.99% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dotnet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.